[Mlir-commits] [mlir] [MLIR] Fix -remove-dead-values with external function & deleted arguments (PR #99671)

[Mehdi Amini]

================
@@ -1124,15 +1124,15 @@ static void getGenericEffectsImpl(
         &effects,
     LinalgOp linalgOp) {
   for (auto [index, operand] : llvm::enumerate(linalgOp.getDpsInputs())) {
-    if (!llvm::isa<MemRefType>(operand.getType()))
+    if (!operand || !llvm::isa<MemRefType>(operand.getType()))
----------------
joker-eph wrote:

> Since we remove dead values in chronological order, we may have removed inputOperand or outputOperand when checking the memory effect of linalgOps.

I would think that should assert: the destructor of a Value is checking for use_empty() I believe.

https://github.com/llvm/llvm-project/pull/99671