[Mlir-commits] [mlir] [mlir] Added new attributes to the llvm.call op in llvmir target (PR #99663)

[llvmlistbot at llvm.org]

FMarno wrote:

> > > Not really to be addressed in this PR, but IMO this and the `llvm.func` counterpart attribute should be called `memory_effects` as it is the case in LLVM IR. @ftynse are you aware of why the LLVM dialect decided to go with this name instead?
> > 
> > 
> > I introduced this a while ago, there is no reason to why it's named like this. Feel free to rename for consistency
> 
> I'd be happy to do this change, but I would rather do it in another PR to minimize the changes here.

I've made a branch for that here: https://github.com/FMarno/llvm-project/tree/mlir_llvmir_rename_memory_attr
I'm going to wait for this to merge before putting up the PR

https://github.com/llvm/llvm-project/pull/99663