[Mlir-commits] [mlir] [mlir] Added new attributes to the llvm.call op in llvmir target (PR #99663)

[Tobias Gysi]

================
@@ -219,6 +219,27 @@ convertOperationImpl(Operation &opInst, llvm::IRBuilderBase &builder,
     }
     call->setCallingConv(convertCConvToLLVM(callOp.getCConv()));
     call->setTailCallKind(convertTailCallKindToLLVM(callOp.getTailCallKind()));
+    if (callOp.getConvergentAttr())
+      call->addFnAttr(llvm::Attribute::Convergent);
+    if (callOp.getNoUnwindAttr())
+      call->addFnAttr(llvm::Attribute::NoUnwind);
+    if (callOp.getWillReturnAttr())
+      call->addFnAttr(llvm::Attribute::WillReturn);
+
+    // memory effects
+    if (MemoryEffectsAttr memAttr = callOp.getMemoryAttr()) {
+      llvm::MemoryEffects newMemEffects =
----------------
gysit wrote:

```suggestion
      llvm::MemoryEffects memEffects =
```
nit: If possible I would avoid new here.

https://github.com/llvm/llvm-project/pull/99663