[Mlir-commits] [mlir] [mlir][vector] Refactor vector-transfer-flatten.mlir (nfc) (3/n) (PR #95745)

Hugo Trachino llvmlistbot at llvm.org
Mon Jul 22 01:18:11 PDT 2024


================
@@ -131,10 +131,42 @@ func.func @transfer_read_dims_mismatch_non_contiguous_non_zero_indices(
 
 // -----
 
-// The input memref has a dynamic trailing shape and hence is not flattened.
-// TODO: This case could be supported via memref.dim
+/// The leading dynamic shapes don't affect whether this example is flattenable
+/// or not. Indeed, those dynamic shapes are not candidates for flattening anyway.
----------------
nujaa wrote:

Hi, not sure if on purpose to highlight comments in opposition to checks with 3 slashes `///` (which I think makes sense). Yet, other comments such as l.108 or l.167 do not implement this. 

https://github.com/llvm/llvm-project/pull/95745


More information about the Mlir-commits mailing list