[Mlir-commits] [mlir] [MLIR] Fix -remove-dead-values with external function & deleted arguments (PR #99671)

[Balaji V. Iyer.]

================
@@ -1124,15 +1124,15 @@ static void getGenericEffectsImpl(
         &effects,
     LinalgOp linalgOp) {
   for (auto [index, operand] : llvm::enumerate(linalgOp.getDpsInputs())) {
-    if (!llvm::isa<MemRefType>(operand.getType()))
+    if (!operand || !llvm::isa<MemRefType>(operand.getType()))
----------------
bviyer wrote:

Why are we checking if operand is a `nullptr`? Shouldn't the `inputOperand` and `outputOperand` be non-null and whoever is removing this operand should removet from these lists as well?

https://github.com/llvm/llvm-project/pull/99671