[Mlir-commits] [flang] [mlir] [MLIR][OpenMP][Flang] Normalize clause arguments names (PR #99505)

Michael Kruse llvmlistbot at llvm.org
Fri Jul 19 06:11:23 PDT 2024


================
@@ -179,46 +179,46 @@ struct PrivateClauseOps {
   llvm::SmallVector<Value> privateVars;
   // The list of symbols referring to delayed privatizer ops (i.e. `omp.private`
   // ops).
-  llvm::SmallVector<Attribute> privatizers;
+  llvm::SmallVector<Attribute> privateSyms;
 };
 
 struct ProcBindClauseOps {
-  ClauseProcBindKindAttr procBindKindAttr;
+  ClauseProcBindKindAttr procBindKind;
 };
 
 struct ReductionClauseOps {
   llvm::SmallVector<Value> reductionVars;
----------------
Meinersbur wrote:

```suggestion
  llvm::SmallVector<Value> reduction;
```
For other clauses, the main clause argument just has the clause's name as well (e.g. `OrderClauseOps`). Why different for reduction, task_reduction, ...?

https://github.com/llvm/llvm-project/pull/99505


More information about the Mlir-commits mailing list