[Mlir-commits] [mlir] [mlir][spirv] Restructure code in `SPIRVConversion.cpp`. NFC. (PR #99393)

[Angel Zhang]

================
@@ -855,16 +899,6 @@ FuncOpConversion::matchAndRewrite(func::FuncOp funcOp, OpAdaptor adaptor,
   return success();
 }
 
-void mlir::populateBuiltinFuncToSPIRVPatterns(SPIRVTypeConverter &typeConverter,
-                                              RewritePatternSet &patterns) {
-  patterns.add<FuncOpConversion>(typeConverter, patterns.getContext());
-}
-
-//===----------------------------------------------------------------------===//
-// func::FuncOp Conversion Patterns
-//===----------------------------------------------------------------------===//
-
-namespace {
 /// A pattern for rewriting function signature to convert vector arguments of
 /// functions to be of valid types
 struct FuncOpVectorUnroll final : OpRewritePattern<func::FuncOp> {
----------------
angelz913 wrote:

Could you please clarify what needs to be changed? It looks like it is already in the form mentioned in the previous form, and `matchAndRewrite` is inlined.

https://github.com/llvm/llvm-project/pull/99393