[Mlir-commits] [mlir] [mlir][spirv] Restructure code in `SPIRVConversion.cpp` (PR #99393)

Jakub Kuderski llvmlistbot at llvm.org
Wed Jul 17 15:03:57 PDT 2024


================
@@ -40,19 +40,21 @@
 
 using namespace mlir;
 
+namespace {
+
 //===----------------------------------------------------------------------===//
 // Utility functions
 //===----------------------------------------------------------------------===//
 
-static int getComputeVectorSize(int64_t size) {
+int getComputeVectorSize(int64_t size) {
----------------
kuhar wrote:

Please leave `static` on this function -- it's somewhat redundant but it makes it easy to know if the current function is private or not 

https://github.com/llvm/llvm-project/pull/99393


More information about the Mlir-commits mailing list