[Mlir-commits] [mlir] [mlir] Add `MLIRContext::executeCriticalSection` and `Pass::getOpDependentDialects` methods. (PR #98953)
Mehdi Amini
llvmlistbot at llvm.org
Mon Jul 15 14:50:26 PDT 2024
================
@@ -513,6 +513,21 @@ LogicalResult OpToOpPassAdaptor::run(Pass *pass, Operation *op,
};
pass->passState.emplace(op, am, dynamicPipelineCallback);
+ // Get any op dependent dialects.
+ DialectRegistry dependentDialects;
+ pass->getOpDependentDialects(op, dependentDialects);
+ MLIRContext &context = pass->getContext();
+ // Only append a non-empty non-trivial registry.
+ if (!dependentDialects.empty() &&
+ !dependentDialects.isSubsetOf(context.getDialectRegistry())) {
+ context.executeCriticalSection([&]() {
+ // Load the dialects.
+ context.appendDialectRegistry(dependentDialects);
+ for (StringRef name : dependentDialects.getDialectNames())
+ context.getOrLoadDialect(name);
----------------
joker-eph wrote:
This seems broken to me: it'll load dialect (and as such change the behavior of the system) while running a pass manager. This will lead to a potentially non-deterministic compiler.
https://github.com/llvm/llvm-project/pull/98953
More information about the Mlir-commits
mailing list