[Mlir-commits] [mlir] [mlir] Allow unroll & jam on SCF loops with results (PR #98887)

Aviad Cohen llvmlistbot at llvm.org
Mon Jul 15 13:14:46 PDT 2024


================
@@ -500,6 +503,8 @@ static bool areInnerBoundsInvariant(scf::ForOp forOp) {
 }
 
 /// Unrolls and jams this loop by the specified factor.
+/// This function doesn't verify that the loop is parallel, if there are true
+/// loop carried dependencies, this function will produce invalid code.
 LogicalResult mlir::loopUnrollJamByFactor(scf::ForOp forOp,
----------------
AviadCo wrote:

Good comment above!
apart from moving the resposbility to the user, should we have minimal checks about the usage of the `iter_args`? are there cases we can always block?

https://github.com/llvm/llvm-project/pull/98887


More information about the Mlir-commits mailing list