[Mlir-commits] [mlir] [mlir][ArmSME] Support filling liveness 'holes' in the tile allocator (PR #98350)

Andrzej WarzyƄski llvmlistbot at llvm.org
Mon Jul 15 03:06:42 PDT 2024


================
@@ -488,76 +501,126 @@ coalesceTileLiveRanges(DenseMap<Value, LiveRange> &initialLiveRanges) {
   return std::move(coalescedLiveRanges);
 }
 
-/// Choose a live range to spill (via some heuristics). This picks either an
-/// active live range from `activeRanges` or the new live range `newRange`.
+/// Choose a live range to spill (via some heuristics). This picks either a live
+/// range from `activeRanges`, `inactiveRanges`, or the new live range
+/// `newRange`. Note: All live ranges in `activeRanges` and `inactiveRanges` are
+/// assumed to overlap with `newRange`.
 LiveRange *chooseSpillUsingHeuristics(ArrayRef<LiveRange *> activeRanges,
+                                      ArrayRef<LiveRange *> inactiveRanges,
----------------
banach-space wrote:

After re-reading this, I realised that `chooseSpillUsingHeuristics` doesn't care about the distinction into `activeRanges` and `inactiveRanges`? If that's the case, then IMO the interface should be like this:
```cpp
LiveRange *chooseSpillUsingHeuristics(ArrayRef<LiveRange *> overlappingRanges)
```

https://github.com/llvm/llvm-project/pull/98350


More information about the Mlir-commits mailing list