[Mlir-commits] [mlir] Remove redundant linalg.matmul_signed (PR #98615)

[Renato Golin]

rengolin wrote:

> Super happy to see changes like this! Perhaps give this another day for others to take a look too. It would also be nice to see how to include mixed signedness as well at some point in the future, maybe with a list of casting functions that defaults to `cast_signed`.

Yes, in the long run we want to be able to mix and match. This also ties in with the transpose side, that we may want to transpose A, B or both, and not necessarily just the two inner dimensions. 

Another topic I was discussing with @ftynse is that we may want to extend opdsl to allow implementation reuse. So we can just name new ops that call the existing implementation with the right attribute arguments. This may not make a lot of sense for matmuls, but it may reduce the convolution implementation footprint considerably.

https://github.com/llvm/llvm-project/pull/98615