[Mlir-commits] [mlir] [mlir][linalg] Decompose winograd operators (PR #96183)

[llvmlistbot at llvm.org]

https://github.com/Max191 requested changes to this pull request.

Thanks for continuing to work on this!

Overall, the decomposition seems okay for the way it is being implemented, but I have some comments about how this will connect to the tiling implementation. The general idea is that the decomposition can either require all dims other than the input tile to be `1`, or require none of them to be `1`. See my comment on the input transform for more details, but this applies to the output transform as well.

https://github.com/llvm/llvm-project/pull/96183