[Mlir-commits] [mlir] [MLIR][Support] A cache for cyclical replacers/maps (PR #98202)

[Billy Zhu]

zyx-billy wrote:

> Amazing. In general, CacledCyclicReplacer doesn't seem very friendly to non-trivial InT and OutT. Whether you want to improve the generics here or just add a disclaimed to the class is up to you

Yeah I was debating how general I should make it given it's currently only used internally for trivial types (raw pointers in the library, ints in tests). Until we have more uses for it, perhaps it's better if I just doubled down on only supporting trivial types and add a disclaimer. At least for most IR concepts in mlir a pointer should be enough.

https://github.com/llvm/llvm-project/pull/98202