[Mlir-commits] [mlir] [mlir][spirv] Implement vector type legalization in function signatures (PR #98337)
Jakub Kuderski
llvmlistbot at llvm.org
Wed Jul 10 09:13:01 PDT 2024
================
@@ -37,20 +37,53 @@ using namespace mlir;
namespace {
/// A pass to perform the SPIR-V conversion.
-struct ConvertToSPIRVPass final
- : impl::ConvertToSPIRVPassBase<ConvertToSPIRVPass> {
+class ConvertToSPIRVPass
+ : public impl::ConvertToSPIRVPassBase<ConvertToSPIRVPass> {
+ using impl::ConvertToSPIRVPassBase<
+ ConvertToSPIRVPass>::ConvertToSPIRVPassBase;
----------------
kuhar wrote:
nit: I think this can be
```suggestion
using impl::ConvertToSPIRVPassBase::ConvertToSPIRVPassBase;
```
https://github.com/llvm/llvm-project/pull/98337
More information about the Mlir-commits
mailing list