[Mlir-commits] [mlir] [mlir][EmitC] Unify handling of operations which are emitted in a deferred way (PR #97804)
Marius Brehler
llvmlistbot at llvm.org
Wed Jul 10 01:21:13 PDT 2024
================
@@ -295,10 +304,10 @@ static bool shouldBeInlined(ExpressionOp expressionOp) {
Operation *user = *result.getUsers().begin();
- // Do not inline expressions used by subscript operations, since the
- // way the subscript operation translation is implemented requires that
- // variables be materialized.
- if (isa<emitc::SubscriptOp>(user))
+ // Do not inline expressions used by operations with deferred emission, since
+ // the way their translation is implemented requires that variables be
+ // materialized.
----------------
marbre wrote:
Maybe rephrase to
```suggestion
// the way their translation is implemented requires that variables are
// materialized.
```
or
```suggestion
// the way their translation is implemented requires to materialize
// variables.
```
or
```suggestion
// their translation requires the materialization of variables.
```
https://github.com/llvm/llvm-project/pull/97804
More information about the Mlir-commits
mailing list