[Mlir-commits] [mlir] e5aa799 - [mojo-lang] Use Lower Case in TailCallAttribute Member Names (#98253)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Jul 9 17:20:35 PDT 2024


Author: Steffi Stumpos
Date: 2024-07-09T17:20:32-07:00
New Revision: e5aa7999bf1bc9a6c7a03bbc65036325a4ec5503

URL: https://github.com/llvm/llvm-project/commit/e5aa7999bf1bc9a6c7a03bbc65036325a4ec5503
DIFF: https://github.com/llvm/llvm-project/commit/e5aa7999bf1bc9a6c7a03bbc65036325a4ec5503.diff

LOG: [mojo-lang] Use Lower Case in TailCallAttribute Member Names (#98253)

The build is broken with the error message:
```
error: declaration of 'mlir::LLVM::tailcallkind::TailCallKind mlir::LLVM::detail::TailCallKindAttrStorage::TailCallKind' changes meaning of 'TailCallKind'
```
I cannot replicate the error locally because I think it's only reported
by GCC not clang. However, I think the change in this patch may fix it.

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
index 25a6ee27b01db..aefc02bce40fb 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
@@ -1082,8 +1082,8 @@ def LLVM_ZeroAttr : LLVM_Attr<"Zero", "zero">;
 //===----------------------------------------------------------------------===//
 
 def TailCallKindAttr : LLVM_Attr<"TailCallKind", "tailcallkind"> {
-  let parameters = (ins "TailCallKind":$TailCallKind);
-  let assemblyFormat = "`<` $TailCallKind `>`";
+  let parameters = (ins "TailCallKind":$tailCallKind);
+  let assemblyFormat = "`<` $tailCallKind `>`";
 }
 
 #endif // LLVMIR_ATTRDEFS


        


More information about the Mlir-commits mailing list