[Mlir-commits] [mlir] [mojo-lang] use lower case (PR #98253)

Steffi Stumpos llvmlistbot at llvm.org
Tue Jul 9 17:18:55 PDT 2024


https://github.com/stumpOS created https://github.com/llvm/llvm-project/pull/98253

The build is broken with the error message:
```
error: declaration of 'mlir::LLVM::tailcallkind::TailCallKind mlir::LLVM::detail::TailCallKindAttrStorage::TailCallKind' changes meaning of 'TailCallKind'
```
I cannot replicate the error locally because I think it's only reported by GCC not clang. However, I think the change in this patch may fix it.

>From b827e4f18216b6a56cbb9e4033c51991f846b4f8 Mon Sep 17 00:00:00 2001
From: Steffi Stumpos <stumposs12 at gmail.com>
Date: Tue, 9 Jul 2024 18:15:46 -0600
Subject: [PATCH] use lower case

---
 mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
index 25a6ee27b01db..aefc02bce40fb 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
@@ -1082,8 +1082,8 @@ def LLVM_ZeroAttr : LLVM_Attr<"Zero", "zero">;
 //===----------------------------------------------------------------------===//
 
 def TailCallKindAttr : LLVM_Attr<"TailCallKind", "tailcallkind"> {
-  let parameters = (ins "TailCallKind":$TailCallKind);
-  let assemblyFormat = "`<` $TailCallKind `>`";
+  let parameters = (ins "TailCallKind":$tailCallKind);
+  let assemblyFormat = "`<` $tailCallKind `>`";
 }
 
 #endif // LLVMIR_ATTRDEFS



More information about the Mlir-commits mailing list