[Mlir-commits] [mlir] Expose Tail Kind Call to MLIR (PR #98080)

Steffi Stumpos llvmlistbot at llvm.org
Tue Jul 9 10:57:06 PDT 2024


stumpOS wrote:

> Thanks for adding the attribute.
> 
> If you can add the attribute to the import as well that would be great!
> 
> It would require an additional line here:
> 
> https://github.com/llvm/llvm-project/blob/2217933c6d3850948dced70097847f5a684ed069/mlir/lib/Target/LLVMIR/ModuleImport.cpp#L1470
> 
> and a test file in the same folder as:
> 
> https://github.com/llvm/llvm-project/blob/bb8998dd3b74a6936452d7ddeb341e79c1d8f001/mlir/test/Target/LLVMIR/Import/calling-convention.ll#L1
> 
> You can use the exported result of your export test to produce an import test.

I responded to the suggestion @gysit ! Let me know if it looks good to you

https://github.com/llvm/llvm-project/pull/98080


More information about the Mlir-commits mailing list