[Mlir-commits] [mlir] [mlir][python] Correctly handle python passes that emit errors without signalling failure. (PR #96996)

[Stella Laurenzo]

stellaraccident wrote:

> Technically, it's possible to also print the error, but I suspect this may encourage folks to rely on this as an error-reporting mechanism instead of fixing the pass.

Yeah, I briefly tried to make it print more. But then I struggled with how to test it, since it would require a questionable pass, and the print logic is non trivial enough that I didn't feel comfortable not testing it...

https://github.com/llvm/llvm-project/pull/96996