[Mlir-commits] [mlir] [mlir][scf] Extend fuse producer to multi-level candidates case (PR #97803)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Jul 8 17:24:32 PDT 2024


================
@@ -835,7 +835,7 @@ getUntiledProducerFromSliceSource(OpOperand *source,
 /// Implementation of fusing producer of a single slice by computing the
 /// slice of the producer in-place.
 std::optional<scf::SCFFuseProducerOfSliceResult>
-mlir::scf::tileAndFuseProducerOfSlice(
+mlir::scf::tileAndFuseProducerOfSliceImpl(
----------------
MaheshRavishankar wrote:

Does this need to be made a publicly exposed method? It makes me squirm when a method that has "impl' in its name is exposed this way. It seems like it is leaking implementation details.

https://github.com/llvm/llvm-project/pull/97803


More information about the Mlir-commits mailing list