[Mlir-commits] [mlir] [MLIR][LLVM] Add ftz and fuse FP ops related function attribute support (PR #97812)

Markus Böck llvmlistbot at llvm.org
Mon Jul 8 02:36:53 PDT 2024


https://github.com/zero9178 approved this pull request.

Not super familiar with these fp functions, but given it mirrors LLVM, its their mess to figure and first and foremost :slightly_smiling_face: 
LGTM with clang-format addressed. Feel free to ping if no one merged this in a day once CI is green.

Given that some of these only have a finite set of limited values afaik, we could turn these into an enum attribute in the future. But this can be a future iteration.

> @zero9178 Hi, i still need an extra approval, Could you help take a look?

FYI, there is no such general rule in LLVM that you need to have more than one approval, although you're of course free to get more eyes on the review :slightly_smiling_face:! Sometimes the first reviewer will ask you for either more time before landing or another approval if they do not feel comfortable being the only approval, but that is not applicable here.

https://github.com/llvm/llvm-project/pull/97812


More information about the Mlir-commits mailing list