[mlir] [MLIR][Linalg] Add aggregate ops decomposition pass and softmax decom… (PR #97582)

Andrzej Warzyński llvmlistbot at llvm.org
Mon Jul 8 02:36:51 PDT 2024


================
@@ -0,0 +1,157 @@
+// RUN: mlir-opt %s -split-input-file -linalg-decompose-named-ops | FileCheck %s
+// RUN: mlir-opt %s -split-input-file -linalg-decompose-named-ops -linalg-generalize-named-ops | FileCheck %s --check-prefix=GENERALIZECHECK
----------------
banach-space wrote:

[nit] With more than one CHECK prefix, you can drop `CHECK` (which is just noise IMHO), and leverage the prefixes to better document what's tested:
```
// RUN: mlir-opt %s -split-input-file -linalg-decompose-named-ops | FileCheck %s -check-prefix=DECOMPOSED
// RUN: mlir-opt %s -split-input-file -linalg-decompose-named-ops -linalg-generalize-named-ops | FileCheck %s --check-prefix=GENERALIZED
```

I am also making the suggestion to make sure that my understanding is correct.

https://github.com/llvm/llvm-project/pull/97582


More information about the Mlir-commits mailing list