[Mlir-commits] [mlir] [MLIR][LLVM] Add ftz and fuse FP ops related function attribute support (PR #97812)

[Tobias Gysi]

================
@@ -344,6 +344,72 @@ declare void @func_attr_no_signed_zeros_fp_math_true() "no-signed-zeros-fp-math"
 ; CHECK-SAME: attributes {no_signed_zeros_fp_math = false}
 declare void @func_attr_no_signed_zeros_fp_math_false() "no-signed-zeros-fp-math"="false"
 
+; // -----
+
+; CHECK-LABEL: @func_attr_denormal_fp_math_ieee
+; CHECK-SAME: attributes {denormal_fp_math = "ieee"}
+declare void @func_attr_denormal_fp_math_ieee() "denormal-fp-math"="ieee"
----------------
gysit wrote:

Ok! I saw there is already prior art above. 

I think the point I tried to make is that testing different values would make a lot of sense if the stored value would be an enum. Then we want to test that all enum values exist and are handled properly. In this case, we store a string so if one works all other strings should work as well (there are no separate code paths for different enum values). For maintenance reasons, I would thus keep the test set minimal if there is no extra functionality (in the sense of code coverage) that is tested.



https://github.com/llvm/llvm-project/pull/97812