[Mlir-commits] [mlir] [mlir][Transforms] Dialect conversion: Fix missing source materialization (PR #97903)

[Markus Böck]

================
@@ -2844,18 +2847,10 @@ static LogicalResult legalizeUnresolvedMaterialization(
     switch (mat.getMaterializationKind()) {
     case MaterializationKind::Argument:
----------------
zero9178 wrote:

I am slightly confused by the comment at line 2804 which states that this code only deals with target materializations (I am interpreting this as a materializations to the target type system, not specifically target conversions).
Doesn't the argument materialization now returning values from the source source type system somewhat contradict this? Same with the fallback to target materialization which is guaranteed to return a different type.

It seems me either the comment needs to be updated or the fallback path can be removed or changed

https://github.com/llvm/llvm-project/pull/97903