[Mlir-commits] [mlir] [mlir][Transforms] Dialect conversion: Fix missing source materialization (PR #97903)

[Matthias Springer]

matthias-springer wrote:

@d0k @jreiffers This commit fixes the test case that you provided in https://github.com/llvm/llvm-project/pull/96207#issuecomment-2193945330. (The dialect conversion framework currently lowers your test case incorrectly.) The test case that I added to this commit is an adaptation of your test case.

Could you run a Presubmit and report back if something else is breaking? Unfortunately, our dialect conversion test coverage in MLIR is not very good.

Note: Argument materializations now behave slightly different, so changes may be needed for `addArgumentMaterialization`. (I added an assertion [here](https://github.com/llvm/llvm-project/pull/97903/files#diff-6d17755f82b46e25824f962e78609e94c540f26e129d74b65ecba6a266a71126R2863) which should detect such cases.)


https://github.com/llvm/llvm-project/pull/97903