[Mlir-commits] [mlir] [mlir][arith] adding comparison regression tests (PR #96974)

Andrzej WarzyƄski llvmlistbot at llvm.org
Sat Jul 6 04:01:09 PDT 2024


banach-space wrote:

> If everyone is generally happy with the format now and has no further comments

I do like the structure (thanks!), but also have a few more comments. I will be sending these shortly. I won't be commenting on other PRs to avoid repetition.

[nit] Please follow https://mlir.llvm.org/getting_started/Contributing/#commit-messages, which links to https://cbea.ms/git-commit/. So, instead of:

> [mlir][arith] adding comparison regression tests

it would be:

> [mlir][arith] Add comparison regression tests

https://github.com/llvm/llvm-project/pull/96974


More information about the Mlir-commits mailing list