[Mlir-commits] [mlir] [mlir][linalg] Fix `linalg.matmul_transpose_a` def. (PR #97690)

Andrzej WarzyƄski llvmlistbot at llvm.org
Fri Jul 5 01:01:34 PDT 2024


banach-space wrote:

> The `matmul_transpose_a` input data format should be `KxM * KxN`.

That's already the case, isn't it? IIUC, this PR is merely changing the variable names in the YAML spec file. Making all definitions use consistent naming is definitely desirable, but the suggested change looks also inconsistent with other example. See my suggestion inline.

Also, this looks like an NFC change, so please update the name and the summary.

https://github.com/llvm/llvm-project/pull/97690


More information about the Mlir-commits mailing list