[Mlir-commits] [mlir] [MLIR] Add the convergent attribute to LLVM Dialect (PR #97709)

[Victor Perez]

victor-eds wrote:

> > Also, modifying the operation assembly format in `mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp` (`FuncOp::parse/print`) would be better than the current syntax IMO.
> 
> There current syntax is in line with other attributes like `no_inline`, `always_inline`, or `alignment`, which seems appropriate to me. examples in this test:
> 
> https://github.com/llvm/llvm-project/blob/a4ea8a48367203b5d4c2fbab49f88ad7f31ab03d/mlir/test/Target/LLVMIR/Import/function-attributes.ll#L349-L357

Seems fair. Thanks! We'd only be missing an export to LLVM IR test then

https://github.com/llvm/llvm-project/pull/97709