[Mlir-commits] [mlir] mlir/Presburger: reinstate use of LogicalResult (PR #97415)
Ramkumar Ramachandra
llvmlistbot at llvm.org
Tue Jul 2 09:35:32 PDT 2024
================
@@ -2201,13 +2203,13 @@ bool IntegerRelation::unionBoundingBox(const IntegerRelation &otherCst) {
if (!extent.has_value())
// TODO: symbolic extents when necessary.
// TODO: handle union if a dimension is unbounded.
- return false;
+ return failure();
auto otherExtent = otherCst.getConstantBoundOnDimSize(
d, &otherLb, &otherLbFloorDivisor, &otherUb);
if (!otherExtent.has_value() || lbFloorDivisor != otherLbFloorDivisor)
// TODO: symbolic extents when necessary.
- return false;
+ return success();
----------------
artagnon wrote:
Will try to get to it in a follow-up patch.
https://github.com/llvm/llvm-project/pull/97415
More information about the Mlir-commits
mailing list