[Mlir-commits] [mlir] mlir/Presburger: reinstate use of LogicalResult (PR #97415)

[Arjun P]

================
@@ -2201,13 +2203,13 @@ bool IntegerRelation::unionBoundingBox(const IntegerRelation &otherCst) {
     if (!extent.has_value())
       // TODO: symbolic extents when necessary.
       // TODO: handle union if a dimension is unbounded.
-      return false;
+      return failure();
 
     auto otherExtent = otherCst.getConstantBoundOnDimSize(
         d, &otherLb, &otherLbFloorDivisor, &otherUb);
     if (!otherExtent.has_value() || lbFloorDivisor != otherLbFloorDivisor)
       // TODO: symbolic extents when necessary.
-      return false;
+      return success();
----------------
Superty wrote:

shouldn't this be `failure()`? (or was it originally `success()` that was changed into `false` in the previous patch?)

https://github.com/llvm/llvm-project/pull/97415