[Mlir-commits] [mlir] [mlir][vector] Make the in_bounds attribute mandatory (PR #97049)

Diego Caballero llvmlistbot at llvm.org
Mon Jul 1 16:16:58 PDT 2024


================
@@ -1363,7 +1363,7 @@ def Vector_TransferReadOp :
                    AffineMapAttr:$permutation_map,
                    AnyType:$padding,
                    Optional<VectorOf<[I1]>>:$mask,
-                   OptionalAttr<BoolArrayAttr>:$in_bounds)>,
+                   BoolArrayAttr:$in_bounds)>,
----------------
dcaballe wrote:

I think we could minimize the impact in tests if we use `DefaultValuedAttr` to set inbound dims to `false` and avoid printing that case. That should "mostly" preserve the existing behavior while fixing the optionality ambiguity.

https://github.com/llvm/llvm-project/pull/97049


More information about the Mlir-commits mailing list