[Mlir-commits] [mlir] [MLIR][NVVM] Reduce the scope of the LLVM_HAS_NVPTX_TARGET guard (PR #97349)

Fabian Mora llvmlistbot at llvm.org
Mon Jul 1 15:14:07 PDT 2024


================
@@ -48,9 +48,7 @@ void GpuModuleToBinaryPass::getDependentDialects(
   // Register all GPU related translations.
   registry.insert<gpu::GPUDialect>();
   registry.insert<LLVM::LLVMDialect>();
-#if LLVM_HAS_NVPTX_TARGET
   registry.insert<NVVM::NVVMDialect>();
-#endif
 #if MLIR_ENABLE_ROCM_CONVERSIONS
   registry.insert<ROCDL::ROCDLDialect>();
 #endif
----------------
fabianmcg wrote:

Do we need this registration calls? As far as I can tell, no, all these dialects should already be in the context by the time this pass gets invoked.

https://github.com/llvm/llvm-project/pull/97349


More information about the Mlir-commits mailing list