[Mlir-commits] [mlir] [mlir] Make MLIR Python sources idempotent (PR #97167)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Jul 1 14:27:03 PDT 2024


https://github.com/akirchhoff-modular approved this pull request.

Looks good to me. I was initially confused why we were creating a list of paths to use as `DEPENDS` later rather than using `add_dependencies` as we go, but I now see in the CMake documentation that `add_dependencies` is only for top-level targets to depend on other top-level targets, so a list is in fact needed and this PR as-is makes sense.

https://github.com/llvm/llvm-project/pull/97167


More information about the Mlir-commits mailing list