[Mlir-commits] [mlir] [mlir][arith] adding comparison regression tests (PR #96974)

Jacob Yu llvmlistbot at llvm.org
Mon Jul 1 07:09:23 PDT 2024


pingshiyu wrote:

> Thanks! Could you try to structure this similarly that what you did for #96973? Similar comment re variable names (prefer underscores to hyphens) and re where to place `CHECK` lines (near the corresponding `vector.print`).
> 
> It might be easier to finish #96973 and #96975 first, and then just replicate the style that we establish there.

Yep that's the plan! Once the other two PRs are done I'll use the same style as used there (and for the rest of the tests)

https://github.com/llvm/llvm-project/pull/96974


More information about the Mlir-commits mailing list