[Mlir-commits] [mlir] [mlir][docs] Fix mistakes in data flow analysis code example (PR #97286)
Matthias Springer
llvmlistbot at llvm.org
Mon Jul 1 05:10:00 PDT 2024
https://github.com/matthias-springer created https://github.com/llvm/llvm-project/pull/97286
None
>From 8adeb39dc6a734e6a83b9a8654adf5ae95a484bb Mon Sep 17 00:00:00 2001
From: Matthias Springer <mspringer at nvidia.com>
Date: Mon, 1 Jul 2024 14:06:56 +0200
Subject: [PATCH] [mlir][docs] Fix mistakes in data flow analysis code example
---
mlir/docs/Tutorials/DataFlowAnalysis.md | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/mlir/docs/Tutorials/DataFlowAnalysis.md b/mlir/docs/Tutorials/DataFlowAnalysis.md
index 8265eff8b6ec7..ea7158fb7391d 100644
--- a/mlir/docs/Tutorials/DataFlowAnalysis.md
+++ b/mlir/docs/Tutorials/DataFlowAnalysis.md
@@ -114,10 +114,10 @@ struct MetadataLatticeValue {
// only keep information that is the same. This means that we only keep
// facts that are true in both.
MetadataLatticeValue result;
- for (const auto &lhsIt : lhs) {
+ for (const auto &lhsIt : lhs.metadata) {
// As noted above, we only merge if the values are the same.
auto it = rhs.metadata.find(lhsIt.first);
- if (it == rhs.metadata.end() || it->second != lhsIt.second)
+ if (it == rhs.metadata.end() || it.second != lhsIt.second)
continue;
result.insert(lhsIt);
}
@@ -129,10 +129,13 @@ struct MetadataLatticeValue {
bool operator==(const MetadataLatticeValue &rhs) const {
if (metadata.size() != rhs.metadata.size())
return false;
- // Check that the 'rhs' contains the same metadata.
- return llvm::all_of(metadata, [&](auto &it) {
- return rhs.metadata.count(it.second);
- });
+ // Check that `rhs` contains the same metadata.
+ for (const auto &it : metadata) {
+ auto rhsIt = rhs.metadata.find(it.first);
+ if (rhsIt == rhs.metadata.end() || it.second != rhsIt.second)
+ return false;
+ }
+ return true;
}
/// Our value represents the combined metadata, which is originally a
More information about the Mlir-commits
mailing list