[Mlir-commits] [mlir] [mlir][ArmSME] Fold extracts from 3D create_masks of SME-like masks (PR #80148)
Cullen Rhodes
llvmlistbot at llvm.org
Wed Jan 31 22:41:00 PST 2024
c-rhodes wrote:
> > Functionally the rewrite looks good to me, but I am wondering if it should be moved alongside Vector dialect transforms. I know this is only relevant for ArmSME right now but semantically these operations and types are expressible in the Vector dialect and if we pretended there were another target where 2-D scalable vector types were relevant then this would apply equally as well I think?
>
> I don't want to muddy the vector dialect with rewrites like this, `-arm-sme-vector-legalization` was always intended to include rewrites like this (it purely works at the vector dialect level already). The reasons for this rewrite are tied to SME and how the current lowering decomposes masks, and I feel it's unlikely to become generally useful.
I thought the same for code I specifically wrote for SVE in the past but it turned out to not be the case :)
But I do understand it's not obvious this will be generally useful, and probably more so than previous examples I'm referring to. There is a ton of common infrastructure we're benefiting from here and it's good to pay it forward where we can, but finding that line isn't always easy.
>
> It also makes things simpler to have everything in one place when it comes to integrating stuff into IREE.
Hadn't considered IREE integration.
https://github.com/llvm/llvm-project/pull/80148
More information about the Mlir-commits
mailing list