[Mlir-commits] [mlir] [mlir][ArmSME] Add initial SME vector legalization pass (PR #79152)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Posting these comments now as I need to be AFK for a while.

My general impression is that this is missing a clearly defined input and output formats. In the context of this pass, what is a tile?
* SME tile that can me mapped onto hardware virtual tile?
* Linalg tile (as in a generic tile after Linalg tiling)?

What do we get after this decomposition? Also tiles? Perhaps something along the lines:
> Maps "generic" 2D scalable tiles (as produced by the Linalg tiling and vectorisation logic) into "SME" 2D tiles (smaller 2D scalable tiles) that match the size of SME virtual tiles (as available in hardware).

Basically, variable names like `tileTile` are a hint that we need to expand the dictionary a bit :-) Perhaps just use `GenericTile` and `SMESubTile`?

https://github.com/llvm/llvm-project/pull/79152