[Mlir-commits] [mlir] [flang] [mlir][TilingInterface] Use `LoopLikeOpInterface` in tiling using SCF to unify tiling with `scf.for` and `scf.forall`. (PR #77874)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Thu Jan 25 15:25:29 PST 2024
MaheshRavishankar wrote:
> This PR looks fine to me, thanks!
>
> I'd like to see the cleanup work truly start before we land more code.
>
> ```
> There is lot of context here spread all over the place w.r.t tiling. I want to unify all of it, but I dont think I can do that in one step. I would rather incrementally build up the required functionality in one place and deprecate/move pieces as needed. I do plan to do this in short order though..
> ```
>
> To be clear, I did not ask for a making this PR more complex but specifically asked for a followup PR to see that work has truly unambiguously started on the deprecation of the legacy implementation (I already voiced this back in Nov: [#72178 (comment)](https://github.com/llvm/llvm-project/pull/72178#issuecomment-1810872756)).
>
> Now is the time to see concrete movement on the deprecation before we land more code.
I agree, my next step is to move the transform dialect op to use this implementation. So thats top on the list.
https://github.com/llvm/llvm-project/pull/77874
More information about the Mlir-commits
mailing list