[Mlir-commits] [mlir] [memref] Support dense resources for memref-to-llvm (PR #79380)

Rob Suderman llvmlistbot at llvm.org
Wed Jan 24 16:33:27 PST 2024


rsuderman wrote:

> This will probably have the same failures because you would interpret the bytes differently on big endian systems and the test will not match. So even if it is correct, your test will fail, because the answer is dependent on endianness.
> 
> This also needs some tests for non-splat values.

Non-splat case added.

I am a little confused by your comments: are you saying that if endianness matters it will fail no matter what, or even if this test passes it may not be correct.

Thanks!

https://github.com/llvm/llvm-project/pull/79380


More information about the Mlir-commits mailing list