[Mlir-commits] [mlir] [MLIR] Added check for IsTerminator trait (PR #79317)

[Mehdi Amini]

================
@@ -598,6 +598,9 @@ void RemoveDeadValues::runOnOperation() {
       // Nothing to do because this terminator is associated with either a
       // function op or a region branch op and gets cleaned when these ops are
       // cleaned.
+    } else if (op->hasTrait<::mlir::OpTrait::IsTerminator>()) {
+      // Nothing to do here because this a terminator op and it should be
+      // honored with respect to its parent
----------------
joker-eph wrote:

Which check are you referring to? The new one?

You may have read it the opposite of what I wrote: I am referring to the **existing** checks being obsolete after this patch.

https://github.com/llvm/llvm-project/pull/79317