[Mlir-commits] [mlir] [MLIR][Presburger] Preserve identifiers in IntegerRelation::convertVa… (PR #67909)

[Kunwar Grover]

Groverkss wrote:

> That sounds like a good idea. Do you suggest making Matrix::moveRows into a separate patch?
> […](#)
> On Mon, 2 Oct, 2023, 16:04 Kunwar Grover, ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In mlir/lib/Analysis/Presburger/IntegerRelation.cpp <[#67909 (comment)](https://github.com/llvm/llvm-project/pull/67909#discussion_r1342600821)>: > + // Save the space as the insert/delete vars operations affect the identifier + // information in the space. + PresburgerSpace oldSpace = space; + Not the biggest fan of this solution. A better solution according to me is implementing a moveRows function in Matrix, calculating what offsets to move and calling moveRows here, and then just calling convertVarKind on the space. — Reply to this email directly, view it on GitHub <[#67909 (review)](https://github.com/llvm/llvm-project/pull/67909#pullrequestreview-1652607076)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG6A4ZV3KBHPN4MC7KY74PTX5KUVLAVCNFSM6AAAAAA5OFLA4SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJSGYYDOMBXGY> . You are receiving this because you were assigned.Message ID: ***@***.***>

Doing it in this patch is fine.

https://github.com/llvm/llvm-project/pull/67909