[Mlir-commits] [mlir] Add support of param type for transform.structured.tile_using_forall (PR #72097)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Fri Jan 19 01:22:58 PST 2024


================
@@ -23,7 +23,7 @@ include "mlir/IR/RegionKindInterface.td"
 // value in the payload IR.
 def TransformParamTypeOrAnyHandle : Type<
     Or<[TransformHandleTypeInterface.predicate,
-        Transform_ParamType.predicate]>,
+        TransformParamTypeInterface.predicate]>,
----------------
ftynse wrote:

Nit: this type constraint is called `TransformParamTypeOrAnyHandle`, indicating that it accepts either `!transform.param` type specifically or any type implementing `TransformHandleTypeInterface`. This change will make it also accept any type implementing `TransformParamTypeInterface`, so it no longer matches the name. Consider renaming to `TransformAnyParamOrOpHandle`.

https://github.com/llvm/llvm-project/pull/72097


More information about the Mlir-commits mailing list