[Mlir-commits] [mlir] [mlir][spirv] Add gpu printf op lowering to spirv.CL.printf op (PR #78510)

Jakub Kuderski llvmlistbot at llvm.org
Wed Jan 17 21:08:40 PST 2024


================
@@ -607,6 +616,108 @@ class GPUSubgroupReduceConversion final
   }
 };
 
+LogicalResult GPUPrintfConversion::matchAndRewrite(
+    gpu::PrintfOp gpuPrintfOp, OpAdaptor adaptor,
+    ConversionPatternRewriter &rewriter) const {
+
+  auto loc = gpuPrintfOp.getLoc();
----------------
kuhar wrote:

nit: do not use `auto` when the actual type is not obvious based on the RHS only
```suggestion
  Location loc = gpuPrintfOp.getLoc();
```

https://github.com/llvm/llvm-project/pull/78510


More information about the Mlir-commits mailing list