[Mlir-commits] [mlir] [mlir][spirv] Add gpu printf op lowering to spirv.CL.printf op (PR #78510)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Wed Jan 17 14:16:55 PST 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 00b6d032a22196bc14e4e30e413c040eb1b65da4 812d1fa2293baf07295d62b35d89fa44876b3d89 -- mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp b/mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp
index 0819880f08..8d9f4554d8 100644
--- a/mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp
+++ b/mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp
@@ -652,7 +652,7 @@ LogicalResult GPUPrintfConversion::matchAndRewrite(
return rewriter.create<mlir::spirv::SpecConstantOp>(
loc, rewriter.getStringAttr(specCstName), attr);
};
-
+
// define GlobalVarOp with printf format string using SpecConstants
// and make composite of SpecConstants
{
@@ -695,7 +695,7 @@ LogicalResult GPUPrintfConversion::matchAndRewrite(
globalVar->setAttr("Constant", rewriter.getUnitAttr());
}
-
+
// Get SSA value of Global variable
mlir::Value globalPtr =
rewriter.create<mlir::spirv::AddressOfOp>(loc, globalVar);
``````````
</details>
https://github.com/llvm/llvm-project/pull/78510
More information about the Mlir-commits
mailing list