[Mlir-commits] [mlir] [mlir][ArmSME] Add arith-to-arm-sme conversion pass (PR #78197)

Benjamin Maxwell llvmlistbot at llvm.org
Wed Jan 17 09:12:39 PST 2024


================
@@ -322,16 +239,17 @@ struct BroadcastOpToArmSMELowering
 
     auto initTile = rewriter.create<arm_sme::GetTileOp>(loc, tileType);
 
+    auto callback = [&](OpBuilder &b, Location loc, Value tileSliceIndex,
----------------
MacDue wrote:

very nit: Within the rewrites themselves a slightly more descriptive name would be okay:
```suggestion
    auto makeLoopBody = [&](OpBuilder &b, Location loc, Value tileSliceIndex,
```
(My previous comment was about `LoopBodyBuilder` in the `arm_sme` namespace level).

https://github.com/llvm/llvm-project/pull/78197


More information about the Mlir-commits mailing list