[Mlir-commits] [mlir] 74cf9bc - Apply clang-tidy fixes for performance-unnecessary-value-param in Utils.cpp (NFC)

[Mehdi Amini]

Author: Mehdi Amini
Date: 2024-01-17T08:51:41-08:00
New Revision: 74cf9bcf71d94f4df80578bccec6ed6d51dd9682

URL: https://github.com/llvm/llvm-project/commit/74cf9bcf71d94f4df80578bccec6ed6d51dd9682
DIFF: https://github.com/llvm/llvm-project/commit/74cf9bcf71d94f4df80578bccec6ed6d51dd9682.diff

LOG: Apply clang-tidy fixes for performance-unnecessary-value-param in Utils.cpp (NFC)

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/GPU/TransformOps/Utils.h
    mlir/lib/Dialect/GPU/TransformOps/Utils.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/GPU/TransformOps/Utils.h b/mlir/include/mlir/Dialect/GPU/TransformOps/Utils.h
index 6ec5fc53d81eca..c65f522e018769 100644
--- a/mlir/include/mlir/Dialect/GPU/TransformOps/Utils.h
+++ b/mlir/include/mlir/Dialect/GPU/TransformOps/Utils.h
@@ -66,7 +66,7 @@ struct GpuIdBuilder {
 
   GpuIdBuilder() = default;
   GpuIdBuilder(MLIRContext *ctx, bool useLinearMapping,
-               MappingIdBuilderFnType builder);
+               const MappingIdBuilderFnType &builder);
 
   /// The mapping attributes targeted by this generator.
   SmallVector<DeviceMappingAttrInterface> mappingAttributes;

diff  --git a/mlir/lib/Dialect/GPU/TransformOps/Utils.cpp b/mlir/lib/Dialect/GPU/TransformOps/Utils.cpp
index df6338897c1660..02a61ed74d6291 100644
--- a/mlir/lib/Dialect/GPU/TransformOps/Utils.cpp
+++ b/mlir/lib/Dialect/GPU/TransformOps/Utils.cpp
@@ -169,7 +169,7 @@ namespace transform {
 namespace gpu {
 
 GpuIdBuilder::GpuIdBuilder(MLIRContext *ctx, bool useLinearMapping,
-                           MappingIdBuilderFnType fn)
+                           const MappingIdBuilderFnType &fn)
     : mappingAttributes(), idBuilder() {
   if (useLinearMapping) {
     for (uint64_t d = static_cast<uint64_t>(MappingId::LinearDim0),