[Mlir-commits] [mlir] [mlir][transform] Add transform.get_operand op (PR #78397)

[Quinn Dawkins]

qedawkins wrote:

> Looks good in principle.
> 
> An overall design comment: we have a similar mechanism in Linalg matcher operations, e.g. https://mlir.llvm.org/docs/Dialects/Transform/#transformmatchstructuredinit-transformmatchstructuredinitop. It has more advanced addressing modes, e.g., associating a list of operands with the result. Not necessarily arguing to adopt all of that here immediately or at all, but I'd recommend using an explicit token/attribute to indicate that `all` operands are requested instead of omitting the attribute.

Good suggestion, I like the linalg matcher approach more so I just imported it. I'll leave this open for a day or so to give a chance to review if you want to check that I got the code shuffling right.

https://github.com/llvm/llvm-project/pull/78397