[Mlir-commits] [mlir] [mlir][transform] Add transform.get_operand op (PR #78397)
Oleksandr Alex Zinenko
llvmlistbot at llvm.org
Wed Jan 17 01:05:11 PST 2024
https://github.com/ftynse approved this pull request.
Looks good in principle.
An overall design comment: we have a similar mechanism in Linalg matcher operations, e.g. https://mlir.llvm.org/docs/Dialects/Transform/#transformmatchstructuredinit-transformmatchstructuredinitop. It has more advanced addressing modes, e.g., associating a list of operands with the result. Not necessarily arguing to adopt all of that here immediately or at all, but I'd recommend using an explicit token/attribute to indicate that `all` operands are requested instead of omitting the attribute.
https://github.com/llvm/llvm-project/pull/78397
More information about the Mlir-commits
mailing list