[Mlir-commits] [mlir] be690ea - [Coroutines] Fix incorrect attribute name coroutine.presplit (NFC) (#78296)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Tue Jan 16 08:35:13 PST 2024
Author: yonillasky
Date: 2024-01-16T17:35:07+01:00
New Revision: be690ea3dbd3b92265ecf620b158f4715c97d040
URL: https://github.com/llvm/llvm-project/commit/be690ea3dbd3b92265ecf620b158f4715c97d040
DIFF: https://github.com/llvm/llvm-project/commit/be690ea3dbd3b92265ecf620b158f4715c97d040.diff
LOG: [Coroutines] Fix incorrect attribute name coroutine.presplit (NFC) (#78296)
Those are probably leftovers from an old name of the same attribute.
Fixed for the sake of consistency.
Co-authored-by: Yoni Lavi <yoni.lavi at nextsilicon.com>
Added:
Modified:
llvm/lib/Transforms/Coroutines/CoroEarly.cpp
mlir/lib/Dialect/Async/Transforms/AsyncToAsyncRuntime.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Transforms/Coroutines/CoroEarly.cpp b/llvm/lib/Transforms/Coroutines/CoroEarly.cpp
index d510b90d9dec6d..489106422e199c 100644
--- a/llvm/lib/Transforms/Coroutines/CoroEarly.cpp
+++ b/llvm/lib/Transforms/Coroutines/CoroEarly.cpp
@@ -203,7 +203,7 @@ void Lowerer::lowerEarlyIntrinsics(Function &F) {
if (CII->getInfo().isPreSplit()) {
assert(F.isPresplitCoroutine() &&
"The frontend uses Swtich-Resumed ABI should emit "
- "\"coroutine.presplit\" attribute for the coroutine.");
+ "\"presplitcoroutine\" attribute for the coroutine.");
setCannotDuplicate(CII);
CII->setCoroutineSelf();
CoroId = cast<CoroIdInst>(&I);
diff --git a/mlir/lib/Dialect/Async/Transforms/AsyncToAsyncRuntime.cpp b/mlir/lib/Dialect/Async/Transforms/AsyncToAsyncRuntime.cpp
index d1a913409ca366..828f53c16d8f86 100644
--- a/mlir/lib/Dialect/Async/Transforms/AsyncToAsyncRuntime.cpp
+++ b/mlir/lib/Dialect/Async/Transforms/AsyncToAsyncRuntime.cpp
@@ -242,7 +242,7 @@ static CoroMachinery setupCoroMachinery(func::FuncOp func) {
// continuations, and will conditionally branch to cleanup or suspend blocks.
// The switch-resumed API based coroutine should be marked with
- // coroutine.presplit attribute to mark the function as a coroutine.
+ // presplitcoroutine attribute to mark the function as a coroutine.
func->setAttr("passthrough", builder.getArrayAttr(
StringAttr::get(ctx, "presplitcoroutine")));
More information about the Mlir-commits
mailing list